Skip to content

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Feb 2, 2023

Related to - woocommerce/woocommerce-ios#8806

Changes

  • ExPlat returns optional instead of assuming control as experiment variation. This lets the client know that there is no variation for an experiment.
  • Make Variation confirm to codable.

Why

In WooCommerce iOS, we will cache the variations for the logged-out experiments. We are doing this to try to remove the high crossovers in Abacus that we face for logged-out experiments.

Choosing this solution after exploring other options. More background in woocommerce/woocommerce-ios#8788

Testing


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@selanthiraiyan selanthiraiyan marked this pull request as ready for review February 2, 2023 04:28
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@selanthiraiyan selanthiraiyan merged commit 9f8acb5 into trunk Feb 2, 2023
@selanthiraiyan selanthiraiyan deleted the wcios/optional-variation branch February 2, 2023 06:59
@selanthiraiyan selanthiraiyan mentioned this pull request Feb 2, 2023
1 task
@selanthiraiyan selanthiraiyan mentioned this pull request Feb 3, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants